mirror of
https://github.com/0rangebananaspy/authelia.git
synced 2024-09-14 22:47:21 +07:00
3816aa4df2
Session fixation attacks were prevented because a session ID was regenerated at each first factor authentication but this commit generalize session regeneration from first to second factor too. Fixes #180
53 lines
1.5 KiB
Go
53 lines
1.5 KiB
Go
package handlers
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/authelia/authelia/internal/authentication"
|
|
"github.com/authelia/authelia/internal/middlewares"
|
|
)
|
|
|
|
// SecondFactorTOTPPost validate the TOTP passcode provided by the user.
|
|
func SecondFactorTOTPPost(totpVerifier TOTPVerifier) middlewares.RequestHandler {
|
|
return func(ctx *middlewares.AutheliaCtx) {
|
|
bodyJSON := signTOTPRequestBody{}
|
|
err := ctx.ParseBody(&bodyJSON)
|
|
|
|
if err != nil {
|
|
ctx.Error(err, mfaValidationFailedMessage)
|
|
return
|
|
}
|
|
|
|
userSession := ctx.GetSession()
|
|
secret, err := ctx.Providers.StorageProvider.LoadTOTPSecret(userSession.Username)
|
|
if err != nil {
|
|
ctx.Error(fmt.Errorf("Unable to load TOTP secret: %s", err), mfaValidationFailedMessage)
|
|
return
|
|
}
|
|
|
|
isValid := totpVerifier.Verify(bodyJSON.Token, secret)
|
|
|
|
if !isValid {
|
|
ctx.Error(fmt.Errorf("Wrong passcode during TOTP validation for user %s", userSession.Username), mfaValidationFailedMessage)
|
|
return
|
|
}
|
|
|
|
err = ctx.Providers.SessionProvider.RegenerateSession(ctx.RequestCtx)
|
|
|
|
if err != nil {
|
|
ctx.Error(fmt.Errorf("Unable to regenerate session for user %s: %s", userSession.Username, err), authenticationFailedMessage)
|
|
return
|
|
}
|
|
|
|
userSession.AuthenticationLevel = authentication.TwoFactor
|
|
err = ctx.SaveSession(userSession)
|
|
|
|
if err != nil {
|
|
ctx.Error(fmt.Errorf("Unable to update the authentication level with TOTP: %s", err), mfaValidationFailedMessage)
|
|
return
|
|
}
|
|
|
|
Handle2FAResponse(ctx, bodyJSON.TargetURL)
|
|
}
|
|
}
|