mirror of
https://github.com/0rangebananaspy/authelia.git
synced 2024-09-14 22:47:21 +07:00
29a900226d
* add new directive in the global scope `certificates_directory` which is used to bulk load certs and trust them in Authelia * this is in ADDITION to system certs and are trusted by both LDAP and SMTP * added a shared TLSConfig struct to be used by both SMTP and LDAP, and anything else in the future that requires tuning the TLS * remove usage of deprecated LDAP funcs Dial and DialTLS in favor of DialURL which is also easier to use * use the server name from LDAP URL or SMTP host when validating the certificate unless otherwise defined in the TLS section * added temporary translations from the old names to the new ones for all deprecated options * added docs * updated example configuration * final deprecations to be done in 4.28.0 * doc updates * fix misc linting issues * uniform deprecation notices for ease of final removal * added additional tests covering previously uncovered areas and the new configuration options * add non-fatal to certificate loading when system certs could not be loaded * adjust timeout of Suite ShortTimeouts * add warnings pusher for the StructValidator * make the schema suites uninform * utilize the warnings in the StructValidator * fix test suite usage for skip_verify * extract LDAP filter parsing into it's own function to make it possible to test * test LDAP filter parsing * update ErrorContainer interface * add tests to the StructValidator * add NewTLSConfig test * move baseDN for users/groups into parsed values * add tests to cover many of the outstanding areas in LDAP * add explicit deferred LDAP conn close to UpdatePassword * add some basic testing to SMTP notifier * suggestions from code review
156 lines
4.9 KiB
Go
156 lines
4.9 KiB
Go
package validator
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
"github.com/authelia/authelia/internal/configuration/schema"
|
|
)
|
|
|
|
type NotifierSuite struct {
|
|
suite.Suite
|
|
configuration schema.NotifierConfiguration
|
|
validator *schema.StructValidator
|
|
}
|
|
|
|
func (suite *NotifierSuite) SetupTest() {
|
|
suite.validator = schema.NewStructValidator()
|
|
suite.configuration.SMTP = &schema.SMTPNotifierConfiguration{
|
|
Username: "john",
|
|
Password: "password",
|
|
Sender: "admin@example.com",
|
|
Host: "example.com",
|
|
Port: 25,
|
|
}
|
|
}
|
|
|
|
func (suite *NotifierSuite) TestShouldEnsureAtLeastSMTPOrFilesystemIsProvided() {
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasWarnings())
|
|
suite.Assert().False(suite.validator.HasErrors())
|
|
|
|
suite.configuration.SMTP = nil
|
|
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasWarnings())
|
|
suite.Require().True(suite.validator.HasErrors())
|
|
|
|
suite.Assert().Len(suite.validator.Errors(), 1)
|
|
|
|
suite.Assert().EqualError(suite.validator.Errors()[0], "Notifier should be either `smtp` or `filesystem`")
|
|
}
|
|
|
|
func (suite *NotifierSuite) TestShouldEnsureEitherSMTPOrFilesystemIsProvided() {
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasErrors())
|
|
|
|
suite.configuration.FileSystem = &schema.FileSystemNotifierConfiguration{
|
|
Filename: "test",
|
|
}
|
|
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasWarnings())
|
|
suite.Require().True(suite.validator.HasErrors())
|
|
|
|
suite.Assert().Len(suite.validator.Errors(), 1)
|
|
|
|
suite.Assert().EqualError(suite.validator.Errors()[0], "Notifier should be either `smtp` or `filesystem`")
|
|
}
|
|
|
|
func (suite *NotifierSuite) TestShouldEnsureFilenameOfFilesystemNotifierIsProvided() {
|
|
suite.configuration.SMTP = nil
|
|
suite.configuration.FileSystem = &schema.FileSystemNotifierConfiguration{
|
|
Filename: "test",
|
|
}
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasWarnings())
|
|
suite.Assert().False(suite.validator.HasErrors())
|
|
|
|
suite.configuration.FileSystem.Filename = ""
|
|
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasWarnings())
|
|
suite.Require().True(suite.validator.HasErrors())
|
|
|
|
suite.Assert().Len(suite.validator.Errors(), 1)
|
|
|
|
suite.Assert().EqualError(suite.validator.Errors()[0], "Filename of filesystem notifier must not be empty")
|
|
}
|
|
|
|
func (suite *NotifierSuite) TestShouldEnsureHostAndPortOfSMTPNotifierAreProvided() {
|
|
suite.configuration.FileSystem = nil
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasWarnings())
|
|
suite.Assert().False(suite.validator.HasErrors())
|
|
|
|
suite.configuration.SMTP.Host = ""
|
|
suite.configuration.SMTP.Port = 0
|
|
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasWarnings())
|
|
suite.Assert().True(suite.validator.HasErrors())
|
|
|
|
errors := suite.validator.Errors()
|
|
|
|
suite.Require().Len(errors, 2)
|
|
|
|
suite.Assert().EqualError(errors[0], "Host of SMTP notifier must be provided")
|
|
suite.Assert().EqualError(errors[1], "Port of SMTP notifier must be provided")
|
|
}
|
|
|
|
func (suite *NotifierSuite) TestShouldEnsureSenderOfSMTPNotifierAreProvided() {
|
|
suite.configuration.FileSystem = nil
|
|
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasWarnings())
|
|
suite.Assert().False(suite.validator.HasErrors())
|
|
|
|
suite.configuration.SMTP.Sender = ""
|
|
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Assert().False(suite.validator.HasWarnings())
|
|
suite.Require().True(suite.validator.HasErrors())
|
|
|
|
suite.Assert().Len(suite.validator.Errors(), 1)
|
|
|
|
suite.Assert().EqualError(suite.validator.Errors()[0], "Sender of SMTP notifier must be provided")
|
|
}
|
|
|
|
// Deprecated: Temporary Test. TODO: Remove in 4.28 (Whole Test).
|
|
func (suite *NotifierSuite) TestShouldReturnDeprecationWarningsFor428() {
|
|
var disableVerifyCert = true
|
|
|
|
suite.configuration.SMTP.TrustedCert = "/tmp"
|
|
suite.configuration.SMTP.DisableVerifyCert = &disableVerifyCert
|
|
|
|
ValidateNotifier(&suite.configuration, suite.validator)
|
|
|
|
suite.Require().True(suite.validator.HasWarnings())
|
|
suite.Assert().False(suite.validator.HasErrors())
|
|
|
|
warnings := suite.validator.Warnings()
|
|
|
|
suite.Require().Len(warnings, 2)
|
|
|
|
suite.Assert().EqualError(warnings[0], "DEPRECATED: SMTP Notifier `disable_verify_cert` option has been replaced by `notifier.smtp.tls.skip_verify` (will be removed in 4.28.0)")
|
|
suite.Assert().EqualError(warnings[1], "DEPRECATED: SMTP Notifier `trusted_cert` option has been replaced by the global option `certificates_directory` (will be removed in 4.28.0)")
|
|
|
|
// Should override since TLS schema is not defined
|
|
suite.Assert().Equal(true, suite.configuration.SMTP.TLS.SkipVerify)
|
|
}
|
|
|
|
func TestNotifierSuite(t *testing.T) {
|
|
suite.Run(t, new(NotifierSuite))
|
|
}
|