mirror of
https://github.com/0rangebananaspy/authelia.git
synced 2024-09-14 22:47:21 +07:00
29a900226d
* add new directive in the global scope `certificates_directory` which is used to bulk load certs and trust them in Authelia * this is in ADDITION to system certs and are trusted by both LDAP and SMTP * added a shared TLSConfig struct to be used by both SMTP and LDAP, and anything else in the future that requires tuning the TLS * remove usage of deprecated LDAP funcs Dial and DialTLS in favor of DialURL which is also easier to use * use the server name from LDAP URL or SMTP host when validating the certificate unless otherwise defined in the TLS section * added temporary translations from the old names to the new ones for all deprecated options * added docs * updated example configuration * final deprecations to be done in 4.28.0 * doc updates * fix misc linting issues * uniform deprecation notices for ease of final removal * added additional tests covering previously uncovered areas and the new configuration options * add non-fatal to certificate loading when system certs could not be loaded * adjust timeout of Suite ShortTimeouts * add warnings pusher for the StructValidator * make the schema suites uninform * utilize the warnings in the StructValidator * fix test suite usage for skip_verify * extract LDAP filter parsing into it's own function to make it possible to test * test LDAP filter parsing * update ErrorContainer interface * add tests to the StructValidator * add NewTLSConfig test * move baseDN for users/groups into parsed values * add tests to cover many of the outstanding areas in LDAP * add explicit deferred LDAP conn close to UpdatePassword * add some basic testing to SMTP notifier * suggestions from code review
79 lines
2.5 KiB
Go
79 lines
2.5 KiB
Go
package validator
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/authelia/authelia/internal/configuration/schema"
|
|
)
|
|
|
|
// ValidateNotifier validates and update notifier configuration.
|
|
//nolint:gocyclo // TODO: Remove in 4.28. Should be able to remove this during the removal of deprecated config.
|
|
func ValidateNotifier(configuration *schema.NotifierConfiguration, validator *schema.StructValidator) {
|
|
if configuration.SMTP == nil && configuration.FileSystem == nil {
|
|
validator.Push(fmt.Errorf("Notifier should be either `smtp` or `filesystem`"))
|
|
return
|
|
}
|
|
|
|
if configuration.SMTP != nil && configuration.FileSystem != nil {
|
|
validator.Push(fmt.Errorf("Notifier should be either `smtp` or `filesystem`"))
|
|
return
|
|
}
|
|
|
|
if configuration.FileSystem != nil {
|
|
if configuration.FileSystem.Filename == "" {
|
|
validator.Push(fmt.Errorf("Filename of filesystem notifier must not be empty"))
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
if configuration.SMTP != nil {
|
|
if configuration.SMTP.StartupCheckAddress == "" {
|
|
configuration.SMTP.StartupCheckAddress = "test@authelia.com"
|
|
}
|
|
|
|
if configuration.SMTP.Host == "" {
|
|
validator.Push(fmt.Errorf("Host of SMTP notifier must be provided"))
|
|
}
|
|
|
|
if configuration.SMTP.Port == 0 {
|
|
validator.Push(fmt.Errorf("Port of SMTP notifier must be provided"))
|
|
}
|
|
|
|
if configuration.SMTP.Sender == "" {
|
|
validator.Push(fmt.Errorf("Sender of SMTP notifier must be provided"))
|
|
}
|
|
|
|
if configuration.SMTP.Subject == "" {
|
|
configuration.SMTP.Subject = schema.DefaultSMTPNotifierConfiguration.Subject
|
|
}
|
|
|
|
if configuration.SMTP.Identifier == "" {
|
|
configuration.SMTP.Identifier = schema.DefaultSMTPNotifierConfiguration.Identifier
|
|
}
|
|
|
|
if configuration.SMTP.TLS == nil {
|
|
configuration.SMTP.TLS = schema.DefaultSMTPNotifierConfiguration.TLS
|
|
|
|
// Deprecated. Maps deprecated values to the new ones. TODO: Remove in 4.28.
|
|
if configuration.SMTP.DisableVerifyCert != nil {
|
|
validator.PushWarning(errors.New("DEPRECATED: SMTP Notifier `disable_verify_cert` option has been replaced by `notifier.smtp.tls.skip_verify` (will be removed in 4.28.0)"))
|
|
|
|
configuration.SMTP.TLS.SkipVerify = *configuration.SMTP.DisableVerifyCert
|
|
}
|
|
}
|
|
|
|
// Deprecated. Maps deprecated values to the new ones. TODO: Remove in 4.28.
|
|
if configuration.SMTP.TrustedCert != "" {
|
|
validator.PushWarning(errors.New("DEPRECATED: SMTP Notifier `trusted_cert` option has been replaced by the global option `certificates_directory` (will be removed in 4.28.0)"))
|
|
}
|
|
|
|
if configuration.SMTP.TLS.ServerName == "" {
|
|
configuration.SMTP.TLS.ServerName = configuration.SMTP.Host
|
|
}
|
|
|
|
return
|
|
}
|
|
}
|