From e6111f775befb1756675d620f1847c33e13fbac0 Mon Sep 17 00:00:00 2001 From: Amir Zarrinkafsh Date: Tue, 12 Jan 2021 12:21:01 +1100 Subject: [PATCH] [CI] Update PR commentary (#1592) This change updates the PR commentary specifically around linting. We now also allow users to submit PR's to Authelia from forked `master` branches as this previously caused issues with codecov. --- .github/probot.js | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/.github/probot.js b/.github/probot.js index b76b584c..d177d94e 100644 --- a/.github/probot.js +++ b/.github/probot.js @@ -24,7 +24,7 @@ on('pull_request.opened') context => !context.payload.pull_request.head.label.includes(':master') ) - .comment(`Thanks for choosing to contribute @{{ pull_request.user.login }}. We lint all PR's with golangci-lint, I may add a review to your PR with some suggestions. + .comment(`Thanks for choosing to contribute @{{ pull_request.user.login }}. We lint all PR's with golangci-lint and eslint, I may add a review to your PR with some suggestions. You are free to apply the changes if you're comfortable, alternatively you are welcome to ask a team member for advice. @@ -32,19 +32,4 @@ You are free to apply the changes if you're comfortable, alternatively you are w These changes once approved by a team member will be published for testing on Buildkite and DockerHub. ### Docker Container -* \`docker pull authelia/authelia:PR{{ pull_request.number }}\``) - -// PR commentary for forked master branches -on('pull_request.opened') - .filter( - context => - context.payload.pull_request.head.label.slice(0, 9) !== 'authelia:' - ) - .filter( - context => - context.payload.pull_request.head.label.includes(':master') - ) - .comment(`Thanks for choosing to contribute @{{ pull_request.user.login }}. - -Unfortunately it appears that you're submitting a PR from a forked master branch and this is known to causes issues with codecov. Please re-submit your PR from a branch other than master.`) - .close() \ No newline at end of file +* \`docker pull authelia/authelia:PR{{ pull_request.number }}\``) \ No newline at end of file