fix: exit setup.sh if missing pre-requisites (#1863)

* fix: fix early exit in setup.sh script

Running the script with missing prerequisites
doesn't fail, but instead warns the user
that return statements aren't allowed here.

* Apply suggestions from code review

Co-authored-by: Amir Zarrinkafsh <nightah@me.com>
This commit is contained in:
RDW 2021-03-30 13:37:34 +02:00 committed by GitHub
parent 6ea62657d9
commit 1db23e5228
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -16,12 +16,12 @@ echo "Checking for pre-requisites"
if [[ ! -x "$(command -v docker)" ]]; then if [[ ! -x "$(command -v docker)" ]]; then
echo "You must install Docker on your machine"; echo "You must install Docker on your machine";
return exit 1
fi fi
if [[ ! -x "$(command -v docker-compose)" ]]; then if [[ ! -x "$(command -v docker-compose)" ]]; then
echo "You must install Docker Compose on your machine"; echo "You must install Docker Compose on your machine";
return exit 1
fi fi
echo "Pulling Authelia docker image for setup" echo "Pulling Authelia docker image for setup"
@ -108,4 +108,3 @@ You will need to authorize the self-signed certificate upon visiting each domain
To visit https://secure.$DOMAIN you will need to register a device for second factor authentication and confirm by clicking on a link sent by email. Since this is a demo with a fake email address, the content of the email will be stored in './authelia/notification.txt'. To visit https://secure.$DOMAIN you will need to register a device for second factor authentication and confirm by clicking on a link sent by email. Since this is a demo with a fake email address, the content of the email will be stored in './authelia/notification.txt'.
Upon registering, you can grab this link easily by running the following command: 'grep -Eo '"https://.*" ' ./authelia/notification.txt'. Upon registering, you can grab this link easily by running the following command: 'grep -Eo '"https://.*" ' ./authelia/notification.txt'.
EOF EOF